Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: remove redundant whitespaces and fix minor typos #33422

Closed
wants to merge 1 commit into from
Closed

docs: remove redundant whitespaces and fix minor typos #33422

wants to merge 1 commit into from

Conversation

thanhpd
Copy link
Contributor

@thanhpd thanhpd commented Oct 26, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

  • Redundant whitespace and new line characters in various files within angular aio docs
  • Some minor typos

Issue Number: N/A

What is the new behavior?

  • Redundant whitespace characters are removed
  • Some typos are corrected

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@thanhpd thanhpd requested review from a team as code owners October 26, 2019 14:41
gkalpak
gkalpak approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @thanhpd 🎉
Can you please change the commit message to docs: ... (i.e. remove the docs-infra part)?

@gkalpak gkalpak added comp: docs action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release type: bug/fix labels Oct 29, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 29, 2019
@thanhpd
Copy link
Contributor Author

thanhpd commented Oct 29, 2019

Hi @gkalpak, I've updated the commit message. Please have a look.

@gkalpak gkalpak changed the title docs(docs-infra): remove redundant whitespaces and fix minor typos docs: remove redundant whitespaces and fix minor typos Oct 29, 2019
@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 29, 2019
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 29, 2019
@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2019

merge-assistance: Global approval for this docs-only change.

@AndrewKushnir AndrewKushnir added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Oct 29, 2019
@AndrewKushnir
Copy link
Contributor

@thanhpd @gkalpak there was a conflict while merging these changes into patch branch, so I merged it to master only for now. Could you please create a separate PR with the necessary changes and target patch branch? Thank you.

@gkalpak
Copy link
Member

gkalpak commented Oct 29, 2019

Thx, @AndrewKushnir 👍
@thanhpd, could you open another PR targetting the 8.2.x branch?

@thanhpd thanhpd mentioned this pull request Oct 30, 2019
Closed
14 tasks
matsko pushed a commit to matsko/angular that referenced this pull request Oct 30, 2019
@thanhpd @matsko
docs: remove redundant whitespaces and fix minor typos (angular#33422)
17276a3 
PR Close angular#33422
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@thanhpd @mohaxspb
docs: remove redundant whitespaces and fix minor typos (angular#33422)
fc6f239 
PR Close angular#33422
mohaxspb pushed a commit to mohaxspb/angular that referenced this pull request Nov 7, 2019
@thanhpd @mohaxspb
docs: remove redundant whitespaces and fix minor typos (angular#33422)
2cbf65d 
PR Close angular#33422
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release type: bug/fix
Projects
None yet
Milestone
needsTriage
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thanhpd @gkalpak @AndrewKushnir @googlebot